Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homework Rubric: 47/50 total
Nice job Taylor! Review your comments here and then close this PR when you're done.
Functionality: 29/30
Completion: 20/20
Bug free: 9/10
Not really a bug, but you have an interesting functionality where in order to edit, the user has to double-click on an item. But single-clicking on an item toggles its completeness, so it toggles and then I assume toggles back after your second click.
Quality: 18/20
See my in-line comments in your code.
Good coding practices: 9/10
Readability: 9/10
This change is